java - Why is this loop becoming infinite when using String.valueOf or Float.toString? -

-

i reading in bytes file using fileinputstream. code (in correct form) follows:

string s = ""; try {         file file = new file(...);         fileinputstream file_input = new fileinputstream(file);         datainputstream data_in = new datainputstream(file_input );          while (true) {             try {                 (int index = 0; index < 4; index++) {                     bytearray[index] = data_in.readbyte();                 }                      } catch (eofexception eof) {                 break;             }              float f = readfloatlittleendian(bytearray); // transforms 4 bytes float             //s += float.tostring(f); <- here's problem          }         data_in.close();     } catch (ioexception e) {         system.err.println(e.tostring());     } } system.out.print(s);

if run code is, loop finishes when reading of file , transforming each set of 4 bytes float.

however, if uncomment line, file never finishes, , seems loop through file on , over. also, printing f (without using float.tostring or string.valueof) not turn infinite loop.

the loop not become infinite - grossly inefficient. problem += on java.lang.string produces new immutable object, discarding 1 held before. each time makes copy, making process o(n2) in terms of number of entries in file.

the fix straightforward - replace string s stringbuilder s, , use append in place of +=.

stringbuilder s = new stringbuilder(); try {     file file = new file(...);     fileinputstream file_input = new fileinputstream(file);     datainputstream data_in = new datainputstream(file_input );     while (true) {         try {             (int index = 0; index < 4; index++) {                 bytearray[index] = data_in.readbyte();             }                  } catch (eofexception eof) {             break;         }         float f = readfloatlittleendian(bytearray); // transforms 4 bytes float         s.append(f);      }     data_in.close(); } catch (ioexception e) {     system.err.println(e.tostring()); } system.out.print(s);

Comments

Post a Comment

Popular posts from this blog

c# - Unity IoC Lifetime per HttpRequest for UserStore -

-
i'm trying clean default implementation of accountcontroller.cs comes out of box in new mvc5/owin security implementation. have modified constructor this: private usermanager<applicationuser> usermanager; public accountcontroller(usermanager<applicationuser> usermanager) { this.usermanager = usermanager; } also, have created lifetime manager unity looks this: public class httpcontextlifetimemanager<t> : lifetimemanager, idisposable { private httpcontextbase _context = null; public httpcontextlifetimemanager() { _context = new httpcontextwrapper(httpcontext.current); } public httpcontextlifetimemanager(httpcontextbase context) { if (context == null) throw new argumentnullexception("context"); _context = context; } public void dispose() { this.removevalue(); } public override object get...
Read more

Change the color of an oval at click in Java AWT -

-
i have draw ovals in java, , @ click change color. beginning tried change color after 20 ms, doesn't work. my code is: public class mycomponentnew extends frame { public graphics2d g2d; public mycomponentnew(string title) { super(title); setsize(400, 550); } @override public void paint(graphics g) { this.g2d = (graphics2d) g; this.g2d.setcolor(color.red); this.g2d.filloval(10, 55, 50, 100); } public void changecolor () { this.g2d.setcolor(color.blue); this.g2d.filloval(10, 55, 50, 100); } } and in class main method have: mycomponentnew m; m = new mycomponentnew("fereastra cu baloane"); m.setvisible(true); m.addwindowlistener(new windowadapter() { @override public void windowclosing(windowevent we) { system.exit(0); } }); try { thread.sleep(20); } catch(interruptedexception e) {} m.changecolor(); the color of oval remains red. ...
Read more

I am trying to solve the error message 'incompatible ranks 0 and 1 in assignment' in a fortran 95 program. -

-
i writing program in fortran find velocity of parachuting person in relation time. keep getting error can't fix. new programming , appreciated. the error is v(i+1)=v(i)+[32-((c*v(i)*v(i))/m)]*(h) 1 error: incompatible ranks 0 , 1 in assignment @ (1) and program is program para integer :: real :: v(11) !velocity real :: q !initial velocity real :: h !time step real :: c !drag coefficient real :: m !mass ! gravity equal 32 ft/s^2 write (*,*)'enter time step' read(*,*)h write(*,*)'enter initial velocity' read(*,*)q write(*,*)'enter drag coefficient' read(*,*)c write(*,*)'enter mass' read(*,*)m i=1,10 ! 1 10, 1 being interval. end v(i+1)=v(i)+[32-((c*v(i)*v(i))/m)]*(h) q=v(1) end program you cannot use [] normal parenthesis in expressions. array constructor, [ items ] means array items elements. end do should after line.
Read more